[webkit-reviews] review granted: [Bug 110352] Move the list counting logic from the render tree to the DOM tree : [Attachment 190269] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 110352: Move the list counting logic from the render tree to the DOM tree
https://bugs.webkit.org/show_bug.cgi?id=110352

Attachment 190269: Patch
https://bugs.webkit.org/attachment.cgi?id=190269&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=190269&action=review


r=me

> Source/WebCore/ChangeLog:3
> +	   Move the list counting logic from the render tree to the DOM tree

The name is bit vague. Move how? "Use DOM ordering for list counts" or
something?

> Source/WebCore/dom/NodeTraversal.h:60
> +// Pre-order traversal including the pseudo-elements.
> +Element* previousWithPseudo(const Element*, const Element* = 0);
> +Element* nextWithPseudo(const Element*, const Element* = 0);
> +Element* previousWithPseudoSkippingChildren(const Element*, const Element* =
0);
> +Element* nextWithPseudoSkippingChildren(const Element*, const Element* = 0);

> +
> +// Traversal helpers aware of pseudo-elements.
> +Element* nextElementSiblingWithPseudo(const Element*);
> +Element* previousElementSiblingWithPseudo(const Element*);
> +Element* firstElementChildWithPseudo(const Element*);
> +Element* lastElementChildWithPseudo(const Element*);

You can drop word "Element", it is already in the namespace name. Also
WithPseudo sounds like you are excluding everything that is not pseudo.
IncludingPseudo perhaps?

It would be nice to not pile everything to NodeTraversal.cpp/.h. However maybe
that can be figure out separately.