[webkit-reviews] review denied: [Bug 110740] Should not return WebTextInputTypeNone for date input element. : [Attachment 190189] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Seigo Nonaka
<nona at chromium.org>'s request for review:
Bug 110740: Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740

Attachment 190189: Patch
https://bugs.webkit.org/attachment.cgi?id=190189&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190189&action=review


> Source/WebKit/chromium/ChangeLog:18
> +	   With this patch, textInputInfo fills type filed regardless of
editable or not, but it is
> +	   safe because textInputType returns editable type only for known
editable element.
> +
> +	   * src/WebViewImpl.cpp:
> +	   (WebKit::WebViewImpl::textInputInfo):

The paragraph should be on the function list like:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable
or not. It is safe because textInputType returns editable type only for known
editable element.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2391
> +    if (node->isElementNode()) {
> +	   HTMLElement* element = static_cast<HTMLElement*>(node);

The code should be:

if (node->isHTMLElement()) {
    HTMLElement* element = toHTMLElement(node);

or

if (node->isElementNode()) {
    Element* element = toElement(node);