[webkit-reviews] review denied: [Bug 110641] WebInspector: Switch hide element shortcut in ElementsPanel to use a selector : [Attachment 190161] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied egraether at chromium.org's
request for review:
Bug 110641: WebInspector: Switch hide element shortcut in ElementsPanel to use
a selector
https://bugs.webkit.org/show_bug.cgi?id=110641

Attachment 190161: Patch
https://bugs.webkit.org/attachment.cgi?id=190161&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190161&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:625
> +		   this._hideShortcutRule = newRule;

There is an inspector stylesheet per document, you can't store them all in a
single variable.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:641
> +		   WebInspector.cssModel.addRule(node.id, hideShortcutSelector,
successCallback.bind(this), failureCallback);

I am still not convinced this will only run once per inspector stylesheet. Here
is the scenario for you:
1) On a page, press "+" in the styles sidebar to add user-defined style rule.
2) Run _toggleHideShortcut

I suspect that resource will be defined and hence you will not add the new
rule.

We might want a test for this.