[webkit-reviews] review granted: [Bug 110424] Web Inspector: Cannot deep expand an element that has previously been partially expanded : [Attachment 190216] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 00:33:49 PST 2013


Pavel Feldman <pfeldman at chromium.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 110424: Web Inspector: Cannot deep expand an element that has previously
been partially expanded
https://bugs.webkit.org/show_bug.cgi?id=110424

Attachment 190216: Patch
https://bugs.webkit.org/attachment.cgi?id=190216&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190216&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:457
> +	       childNodeId = nodeMap->get(node);

you never use childNodeId outside for scope - declare it inline.


More information about the webkit-reviews mailing list