[webkit-reviews] review canceled: [Bug 110816] getPropertyValue for -webkit-marquee returns null, should compute the shorthand value : [Attachment 190151] Patch

Mon Feb 25 21:59:31 PST 2013

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Uday Kiran
<udaykiran at motorola.com>'s request for review:
Bug 110816: getPropertyValue for -webkit-marquee returns null, should compute
the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=110816

Attachment 190151: Patch
https://bugs.webkit.org/attachment.cgi?id=190151&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190151&action=review

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:3
> +<head>

It is a good idea to use proper tag indentation inside the <html> to enhance
readability. Even one space will work, like in getPropertyValue-border.html

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:36
> +description("<a href=\"https://bugs.webkit.org/show_bug.cgi?id=110816\">Bug
110816: getPropertyValue for -webkit-marquee returns null, should compute the
shorthand value</a>");

The code inside <script> should also be indented relative to the <script> tag.

> LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:38
> +function testWebkitMarquee(id) {

This does not actually test the property but returns its value. I believe
"webkitMarqueeValue" will work as a new name.