[webkit-reviews] review granted: [Bug 110797] Shadow DOM styles appear to be over-eagerly shared : [Attachment 190178] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 18:59:58 PST 2013


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 110797: Shadow DOM styles appear to be over-eagerly shared
https://bugs.webkit.org/show_bug.cgi?id=110797

Attachment 190178: Patch
https://bugs.webkit.org/attachment.cgi?id=190178&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190178&action=review


> Source/WebCore/css/StyleResolver.cpp:1102
> +    if (element->parentElement() && element->parentElement()->shadow() &&
element->parentElement()->shadow()->distributor().findInsertionPointFor(element
))

Isn't this super-slow? We need to keep an eye out for better-performing way of
doing this.


More information about the webkit-reviews mailing list