[webkit-reviews] review denied: [Bug 110811] Draw intermediate snapshots if possible : [Attachment 190176] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 110811: Draw intermediate snapshots if possible
https://bugs.webkit.org/show_bug.cgi?id=110811

Attachment 190176: Patch
https://bugs.webkit.org/attachment.cgi?id=190176&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190176&action=review


> Source/WebCore/html/HTMLPlugInImageElement.h:69
> +    Image* snapshotImage() { return m_snapshotImage.get(); }

Can this be const?

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:176
> +    if (element && element->isPluginElement()) {
> +	   HTMLPlugInImageElement* plugInImageElement =
static_cast<HTMLPlugInImageElement*>(element);

This cast looks unsafe; you're only testing isPluginElement(), not if it's a
HTMLPlugInImageElement. Or are the names confusing?

I also think this should be one of those SECURITY_ASSERT-checked casts.

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:180
> +		   if (paintInfo.phase == PaintPhaseForeground)

You should bail earlier with this check, since it's cheap.