[webkit-reviews] review requested: [Bug 110797] Shadow DOM styles appear to be over-eagerly shared : [Attachment 190172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 18:19:14 PST 2013


Takashi Sakamoto <tasak at google.com> has asked  for review:
Bug 110797: Shadow DOM styles appear to be over-eagerly shared
https://bugs.webkit.org/show_bug.cgi?id=110797

Attachment 190172: Patch
https://bugs.webkit.org/attachment.cgi?id=190172&action=review

------- Additional Comments from Takashi Sakamoto <tasak at google.com>
Or just modifying WebCore::StyleResolver::locateCousinList,

line 887:
	    if (currentNode->renderStyle() == parentStyle &&
currentNode->lastC\
hild()
!		&& currentNode->isElementNode() &&
!parentElementPreventsSharin\
g(toElement(currentNode))) {
---
!		 && currentNode->isElementNode() &&
!parentElementPreventsSharin\
g(toElement(currentNode))
+		&& !toElement(currentNode)->shadow()) {


More information about the webkit-reviews mailing list