[webkit-reviews] review granted: [Bug 99393] Add support for 8 bit TextRuns for ports using HarfBuzz or HarfBuzz NG : [Attachment 190149] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 99393: Add support for 8 bit TextRuns for ports using HarfBuzz or HarfBuzz
NG
https://bugs.webkit.org/show_bug.cgi?id=99393

Attachment 190149: Patch
https://bugs.webkit.org/attachment.cgi?id=190149&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190149&action=review


> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:98
> +    String stringFor8BitRun;

So this lives long enough?  normalize doesnt' try to hang onto the bytes?

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:164
> +    String stringFor8BitRun;

So long as this lives long enough.