[webkit-reviews] review denied: [Bug 110733] XSSAuditor should send only one console error when blocking a page. : [Attachment 190060] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 25 13:26:05 PST 2013
Daniel Bates <dbates at webkit.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 110733: XSSAuditor should send only one console error when blocking a page.
https://bugs.webkit.org/show_bug.cgi?id=110733
Attachment 190060: Patch
https://bugs.webkit.org/attachment.cgi?id=190060&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
I'm marking this patch r- since I prefer that the changes to XSSAuditor::init()
be in a separate bug as they aren't related to the purpose described in the bug
description. Additionally, the Mac, Mac WebKit2, and Chromium Linux EWS bots
report that test fast/frames/xss-auditor-handles-file-urls.html fails when this
patch is applied. We'll need to rebase its expected results.
More information about the webkit-reviews
mailing list