[webkit-reviews] review denied: [Bug 107026] Hide the location bar on window.scrollTo(0, [01]) : [Attachment 190072] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 107026: Hide the location bar on window.scrollTo(0,[01])
https://bugs.webkit.org/show_bug.cgi?id=107026

Attachment 190072: Patch
https://bugs.webkit.org/attachment.cgi?id=190072&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190072&action=review


> Source/WebCore/page/Chrome.h:129
> +    void hideLocationBar() const;

I don't think a function like this belongs in Chrome. It makes assumptions
about app behavior. If you want to add some "did scroll to" callback that's OK,
but don't make it about the location bar.