[webkit-reviews] review granted: [Bug 110677] IndexedDB: Histogram all exits from IDBBackingStore::open : [Attachment 189901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 09:50:05 PST 2013


Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 110677: IndexedDB: Histogram all exits from IDBBackingStore::open
https://bugs.webkit.org/show_bug.cgi?id=110677

Attachment 189901: Patch
https://bugs.webkit.org/attachment.cgi?id=189901&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189901&action=review


> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Modules/indexeddb/IDBBackingStore.cpp:

Nit: You should still have a line here saying why there is no test.  E.g., No
tests because this only changes logging code.  In the long run, we may want to
come up with a way to write a test for this in webkit_unit_tests.


More information about the webkit-reviews mailing list