[webkit-reviews] review granted: [Bug 110488] Work around a MSVC 2012 Update 1 bug causing a crash on x86 : [Attachment 190063] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 110488: Work around a MSVC 2012 Update 1 bug causing a crash on x86
https://bugs.webkit.org/show_bug.cgi?id=110488

Attachment 190063: Patch
https://bugs.webkit.org/attachment.cgi?id=190063&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190063&action=review


> Source/WebCore/platform/text/TextEncodingRegistry.cpp:73
> +	       if (c1 != c2)

I think you should put a return false inside the #ifdef.

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:78
> +#endif

And then extend the ifdef below the return false; line.