[webkit-reviews] review granted: [Bug 64575] [soup] "Too many redirects" error loading chat in plus.google.com : [Attachment 190057] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 64575: [soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575

Attachment 190057: Patch
https://bugs.webkit.org/attachment.cgi?id=190057&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190057&action=review


Nice. Just a couple small things before landing.

> LayoutTests/http/tests/cookies/resources/redirect.php:6
> +    if ($_GET['step'] == 1)
> +	   {
> +	       header("HTTP/1.0 302 Found");
> +	       header('Location:
http://localhost:8000/cookies/resources/redirect.php?step=2');
> +	}

Do you mind converting this file to use WebKit style when landing? I also
recommend giving it a slightly more descriptive name. Since it isn't shared,
maybe you can just name it after the test?

> LayoutTests/http/tests/cookies/resources/redirect.php:18
> +		       echo "<p>PASSED: Cookie successfully set</p>\n";

I'm not sure the paragraph tag is necessary here.

> LayoutTests/http/tests/cookies/resources/redirect.php:22
> +		       echo "<p>FAILED: Cookie not set</p>\n";

Ditto.