[webkit-reviews] review denied: [Bug 110732] Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation : [Attachment 190046] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 110732: Web Inspector: Selector's raw start position in its line is
considered to be 0 when computing UILocation
https://bugs.webkit.org/show_bug.cgi?id=110732

Attachment 190046: Patch
https://bugs.webkit.org/attachment.cgi?id=190046&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190046&action=review


> Source/WebCore/inspector/InspectorStyleSheet.cpp:149
> +    ASSERT(m_hasText);

Could you reuse the code in getRegularExpressionMatchesByLines?

> Source/WebCore/inspector/InspectorStyleSheet.cpp:176
> +struct LineColumn {

wtf/text/TextPosition.h

> Source/WebCore/inspector/InspectorStyleSheet.cpp:191
> +    const size_t vectorSize = lineEndings.size();

Move to ContentSearchUtil