[webkit-reviews] review denied: [Bug 110692] [GTK] Move basic dependency installation to a script : [Attachment 190017] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 110692: [GTK] Move basic dependency installation to a script
https://bugs.webkit.org/show_bug.cgi?id=110692

Attachment 190017: Patch
https://bugs.webkit.org/attachment.cgi?id=190017&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190017&action=review


r- because the root check is not running the script as root with sudo and
because the error message is now outdated, also a changelog nit

> Tools/ChangeLog:1
> +2013-02-25  Martin Robinson	<mrobinson at igalia.com>

You should add yourself as co-author, here!

> Tools/gtk/install-dependencies:6
> +if [[ $UID -ne 0 ]]; then
> +    echo "$0 must be run as root"
> +    exit 1
> +fi

The script should use sudo to run itself if it's not yet running as root IMO.
So you'd have sudo $0 inside this if. It should not have two of each of [ and
], too.

> Tools/gtk/install-dependencies:11
> +    echo "Currently this script only works for distributions supporting
apt-get."
> +    echo "Please add support for your distribution:
http://webkit.org/b/110693"

Need to add yum here now =)