[webkit-reviews] review denied: [Bug 110740] Should not return WebTextInputTypeNone for date input element. : [Attachment 190022] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Seigo Nonaka
<nona at chromium.org>'s request for review:
Bug 110740: Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740

Attachment 190022: Patch
https://bugs.webkit.org/attachment.cgi?id=190022&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190022&action=review


> Source/WebKit/chromium/ChangeLog:7
> +	   because textInputType returns same value as non editable element.

Please put information in https://bugs.webkit.org/show_bug.cgi?id=110740#c0
here.

> Source/WebKit/chromium/ChangeLog:10
> +	   (WebKit::WebViewImpl::textInputInfo):

Please write why this change is necessary.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2391
> +    if (node->isElementNode()) {
> +	   HTMLElement* element = static_cast<HTMLElement*>(node);

This can cause bad casts.  You need to check isHTMLElement.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2393
> +	   if (element->isDateTimeFieldElement())
> +	       return WebTextInputTypeDate;

Using WebTextInputTypeDate looks wrong.
- We're going to remove it as written in WebTextInputType.h.
- This issue affects all of date/time types.  WebTextInputTypeDate is only for
input[type=date].

I think using WebTextInputTypeText is better.