[webkit-reviews] review requested: [Bug 91611] [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation : [Attachment 190026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 03:52:43 PST 2013


Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 91611: [GStreamer] Stopping playback of html5 media when receiving a higher
priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Attachment 190026: Patch
https://bugs.webkit.org/attachment.cgi?id=190026&action=review

------- Additional Comments from Xabier Rodríguez Calvar <calvaris at igalia.com>
Updated Qt expectations, made suggested style changes, added #if guards to
avoid the MediaPlayer being added to non GStreamer ports, changed to use
gst_element_post_message and not setting the media role as environment
variable, but as media stream properties on pulsesink.


More information about the webkit-reviews mailing list