[webkit-reviews] review granted: [Bug 110589] Add a scrollbar class for the new calendar picker : [Attachment 190008] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 110589: Add a scrollbar class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110589

Attachment 190008: Patch
https://bugs.webkit.org/attachment.cgi?id=190008&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190008&action=review


> Source/WebCore/Resources/pagepopups/calendarPicker.js:1378
> +    this.knob = createElement("div",
ScrubbyScrollBar.ClassNameScrubbyScrollKnob);

nit: I think we usually call it "thumb" in WebKit, not "knob".

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1522
> +    if (this._knobPosition < 0)
> +	   scrollAmount = -scrollAmount;
> +	   scrollAmount = -scrollAmount;

duplicated lines