[webkit-reviews] review requested: [Bug 110696] Web Inspector: Improve speed of Linkifier.reset operation. : [Attachment 190012] Patch

[bugzilla-daemon at webkit.org]

Andrey Adaikin <aandrey at chromium.org> has asked  for review:
Bug 110696: Web Inspector: Improve speed of Linkifier.reset operation.
https://bugs.webkit.org/show_bug.cgi?id=110696

Attachment 190012: Patch
https://bugs.webkit.org/attachment.cgi?id=190012&action=review

------- Additional Comments from Andrey Adaikin <aandrey at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190012&action=review


> Source/WebCore/inspector/front-end/UISourceCode.js:55
> +	* @type {Object.<number, WebInspector.LiveLocation>}

wrong @type?

> Source/WebCore/inspector/front-end/utilities.js:705
> +var createObjectIdentifier = function()

/** @return {string} */

> Source/WebCore/inspector/front-end/utilities.js:708
> +    return '_' + ++createObjectIdentifier._last;

' -> "

> Source/WebCore/inspector/front-end/utilities.js:718
> +    this._set = {};

plz add @type !Object.<...>

> Source/WebCore/inspector/front-end/utilities.js:739
> +	* @param {Object} item

{Object} -> {!Object}

> Source/WebCore/inspector/front-end/utilities.js:743
> +	   if (this._set[item.__identifier]) {

maybe a check on item.__identifier for consistency with the #add method

> Source/WebCore/inspector/front-end/utilities.js:750
> +	* @return {Array.<Object>}

Array -> !Array

> Source/WebCore/inspector/front-end/utilities.js:762
> +	* @param {Object} item

@return is missing