[webkit-reviews] review granted: [Bug 110597] Web Inspector: move profile type specific code out of ProfilesPanel (refactor) : [Attachment 189778] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 110597: Web Inspector: move profile type specific code out of ProfilesPanel
(refactor)
https://bugs.webkit.org/show_bug.cgi?id=110597

Attachment 189778: Patch
https://bugs.webkit.org/attachment.cgi?id=189778&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189778&action=review


> Source/WebCore/inspector/front-end/ProfilesPanel.js:575
> +	   function onAddProfileHeader(event) {

style: { on the next line

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1007
> +	       searchableViews.splice(0, 0, this.visibleView);

searchableViews.unshift(this.visibleView);

BTW, why does visible view have to go first? Maybe just make a swap(0, i) then?


> Source/WebCore/inspector/front-end/ProfilesPanel.js:1042
> +//	     this._getAllProfiles().forEach(function(profile) {
profile._profilesTreeElement.searchMatches = 0; });

Remove commented code.