[webkit-reviews] review denied: [Bug 110641] WebInspector: Switch hide element shortcut in ElementsPanel to use a selector : [Attachment 189824] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied egraether at chromium.org's
request for review:
Bug 110641: WebInspector: Switch hide element shortcut in ElementsPanel to use
a selector
https://bugs.webkit.org/show_bug.cgi?id=110641

Attachment 189824: Patch
https://bugs.webkit.org/attachment.cgi?id=189824&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189824&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:491
> +		   this._addHideShortcutRuleToInspectorStyleSheet(node.id,
hideShortcutSelector);

You only need to do this once.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:634
> +	       if (!resource)

Resource may exist due to user's add rule action.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:638
> +	   WebInspector.cssModel.getViaInspectorResourceForRule(this._hideRule
|| {}, resourceCallback.bind(this));

We need to move this into model via creating addInspectorRule method that
receives both selector and rule body.