[webkit-reviews] review granted: [Bug 110716] [Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF : [Attachment 189988] Updated patch.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 110716: [Mac] cleanup MediaPlayerPrivateAVFoundation and
InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=110716

Attachment 189988: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=189988&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189988&action=review


> Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:40
> +    virtual ~AVFInbandTrackParent() { }

Since there is already a matching .cpp file, it's better to to have the
implementation there. Inlining destructors and constructors of polymorphic
classes significantly and unnecessarily increases code bloat.