[webkit-reviews] review granted: [Bug 110692] [GTK] Move basic dependency installation to a script : [Attachment 189934] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 110692: [GTK] Move basic dependency installation to a script
https://bugs.webkit.org/show_bug.cgi?id=110692

Attachment 189934: Patch
https://bugs.webkit.org/attachment.cgi?id=189934&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Some people do not use sudo as the main ways of getting something to run as
root, so I think it's a good idea to support a case in which the person decides
for themselves how to become root, by which I mean we should use sudo only if
the script is not already running as root. I think using a SUDO variable that
is set to sudo if a test like if [ "$(id -u)" != "0" ] succeeds and to the
empty string otherwise should do it, otherwise it's a great idea =)