[webkit-reviews] review denied: [Bug 108196] Notification.requestPermission callback should be optional : [Attachment 189847] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 23 12:21:24 PST 2013


Adam Barth <abarth at webkit.org> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 108196: Notification.requestPermission callback should be optional
https://bugs.webkit.org/show_bug.cgi?id=108196

Attachment 189847: Patch
https://bugs.webkit.org/attachment.cgi?id=189847&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm, sorry, but I don't understand what you are saying.  Your patch doesn't
actually change any behavior because this function has Custom bindings.  I
believe your test demonstrates that the argument is not optional.


More information about the webkit-reviews mailing list