[webkit-reviews] review granted: [Bug 110618] [Chromium] Add expandParagraph() method to WebRange : [Attachment 189859] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 23 09:50:30 PST 2013
Adam Barth <abarth at webkit.org> has granted Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 110618: [Chromium] Add expandParagraph() method to WebRange
https://bugs.webkit.org/show_bug.cgi?id=110618
Attachment 189859: Patch
https://bugs.webkit.org/attachment.cgi?id=189859&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189859&action=review
> Source/WebKit/chromium/public/WebRange.h:76
> + WEBKIT_EXPORT WebRange expandParagraph() const;
It looks like the WebCore version mutates the Rang whereas this one returns a
new range that has been expanded. Perhaps we should pick a name like
"expandedToParagraph" to make it clear that we're not mutating the object.
More information about the webkit-reviews
mailing list