[webkit-reviews] review granted: [Bug 110663] SelectorChecker should not know about SelectorCheckerFastPath. : [Attachment 189868] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 110663: SelectorChecker should not know about SelectorCheckerFastPath.
https://bugs.webkit.org/show_bug.cgi?id=110663

Attachment 189868: Patch
https://bugs.webkit.org/attachment.cgi?id=189868&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=189868&action=review


> Source/WebCore/css/SelectorChecker.cpp:77
> -bool SelectorChecker::matches(const CSSSelector* selector, Element* element,
bool isFastCheckableSelector) const
> +bool SelectorChecker::matches(const CSSSelector* selector, Element* element)
const
>  {
> -    if (isFastCheckableSelector && !element->isSVGElement()) {
> -	   SelectorCheckerFastPath selectorCheckerFastPath(selector, element);
> -	   if
(!selectorCheckerFastPath.matchesRightmostSelector(VisitedMatchDisabled))
> -	       return false;
> -	   return selectorCheckerFastPath.matches();
> -    }
> -
>      PseudoId ignoreDynamicPseudo = NOPSEUDO;
>      return match(SelectorCheckingContext(selector, element,
SelectorChecker::VisitedMatchDisabled), ignoreDynamicPseudo,
DOMSiblingTraversalStrategy()) == SelectorMatches;
>  }

Maybe you should just remove this whole function? It does not serve much
purpose anymore.