[webkit-reviews] review granted: [Bug 110673] RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset() : [Attachment 189884] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 110673: RenderLayer::scrollTo() should call
FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673

Attachment 189884: Patch
https://bugs.webkit.org/attachment.cgi?id=189884&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189884&action=review


> Source/WebCore/ChangeLog:6
> +	   RenderLayer::scrollTo() should call
FrameLoaderClient::didChangeScrollOffset()
> +	   https://bugs.webkit.org/show_bug.cgi?id=110673
> +	   -and corresponding-
> +	   <rdar://problem/13258596>

This is perfect.

>> Source/WebCore/ChangeLog:10
>> +	    FrameLoaderClient::didChangeScrollOffset() doesn't get called for
web pages like 
> 
> I have removed the "like" in my local copy.

Like totally.