[webkit-reviews] review granted: [Bug 110668] [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached : [Attachment 189874] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 22 17:39:51 PST 2013
Adam Barth <abarth at webkit.org> has granted David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 110668: [chromium] Remove call to detach WebHelperPluginImpl's frame since
it is never attached
https://bugs.webkit.org/show_bug.cgi?id=110668
Attachment 189874: Patch
https://bugs.webkit.org/attachment.cgi?id=189874&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.
For the folks reading along, we talked a bit about this issue in person.
Currently our plan is for the helper plugin to participate in as little of the
lifecycle as possible. If run into more of these sorts of issues, we should
consider changing the design to use the shadow DOM rather than implementing the
helper plugin in the WebKit layer.
More information about the webkit-reviews
mailing list