[webkit-reviews] review granted: [Bug 110644] Add descriptive names for different addMidpoint use cases : [Attachment 189840] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 110644: Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644

Attachment 189840: Patch
https://bugs.webkit.org/attachment.cgi?id=189840&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189840&action=review


>>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:379
>>> +static inline void ensureLineBox(LineMidpointState& lineMidpointState,
RenderObject* renderer)
>> 
>> How about renaming the function to something like
ensureLineBoxWhileIgnoringSpaces? Though this name seems to suggest as if the
function itself is going to ignore spaces :(
> 
> Either name is an improvement over what we have now. If you prefer that one
I'm happy to change it.

Per IRC discussion, I'd prefer ensureLineBoxInsideIgnoredSpaces.