[webkit-reviews] review granted: [Bug 108577] Upload results to perf.webkit.org in addition to the one specified by --test-results-server : [Attachment 189843] Fixed per comments

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 108577: Upload results to perf.webkit.org in addition to the one specified
by --test-results-server
https://bugs.webkit.org/show_bug.cgi?id=108577

Attachment 189843: Fixed per comments
https://bugs.webkit.org/attachment.cgi?id=189843&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189843&action=review


r+ with the typos fixed.

> Tools/ChangeLog:9
> +	   --test-results-server. The new format is needed to provide of extra
information perf.webkit.org

nit: s/provide of/provide/

> Tools/ChangeLog:12
> +	   webkit-perf.appspot.com will be deleted once the transition is
completed.

webkit-perf.appspot.com can be deleted.

> Tools/ChangeLog:14
> +	   This patch adds scm.svn_timestamp to obtain the timestamp of the
latest commit present in

rename to timestamp_of_latest_commit() in the Changelog?

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:263
> +	   # Manually modify the timezone since Git doesn't have an optiton to
show it in UTC.

typo: "optiton"

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:270
> +	   return time_wihout_timezone.strftime('%Y-%m-%dT%H:%M:%SZ')

typo: "wihout" (both lines)