[webkit-reviews] review granted: [Bug 110644] Add descriptive names for different addMidpoint use cases : [Attachment 189830] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 110644: Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644

Attachment 189830: Patch
https://bugs.webkit.org/attachment.cgi?id=189830&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189830&action=review


You are my hero.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-2662
> -		       ignoreStart.m_obj = current.m_obj;
> -		       ignoreStart.m_pos = 0;

We're just re-using the iterator here?	Is it OK to remove this?

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2940
> -			       if (ignoringSpaces ||
!currentStyle->collapseWhiteSpace() || !currentCharacterIsSpace ||
!previousCharacterIsSpace)
> +			       if (ignoringSpaces || !collapseWhiteSpace ||
!currentCharacterIsSpace || !previousCharacterIsSpace)

I assume these are equivalent?