[webkit-reviews] review granted: [Bug 110498] [GTK] Expose all dependencies to the gyp build : [Attachment 189784] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 110498: [GTK] Expose all dependencies to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=110498

Attachment 189784: Patch
https://bugs.webkit.org/attachment.cgi?id=189784&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189784&action=review


It does seem like generating Dependencies.gyp from a Dependencies.gyp.in might
make things clearer and remove some of the duplication, but this is fine for
now (and up to you).

> Source/WebKit/gtk/gyp/Dependencies.gyp:13
> +

nit: stylistically, we don't usually separate these blocks w/ blank lines.