[webkit-reviews] review granted: [Bug 110481] [Chromium] Disable registerProtocolHandler on Android : [Attachment 189545] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 22 12:44:24 PST 2013
Julien Chaffraix <jchaffraix at webkit.org> has granted Anton Vayvod
<avayvod at chromium.org>'s request for review:
Bug 110481: [Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481
Attachment 189545: Patch
https://bugs.webkit.org/attachment.cgi?id=189545&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189545&action=review
r=me, but the ChangeLog should be amended before landing.
> Source/WebKit/chromium/ChangeLog:12
> +
You should mention the *why* which the original change properly explained: this
is done because Android doesn't wire the implementation and you don't want to
break feature detection. crbug.com/156386 should also be mentioned as it
properly highlight the challenges of implementing it in Android.
More information about the webkit-reviews
mailing list