[webkit-reviews] review granted: [Bug 110520] Add computeInstrinsicLogicalWidths functions to TableLayout subclasses : [Attachment 189662] Sync to ToT

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 110520: Add computeInstrinsicLogicalWidths functions to TableLayout
subclasses
https://bugs.webkit.org/show_bug.cgi?id=110520

Attachment 189662: Sync to ToT
https://bugs.webkit.org/attachment.cgi?id=189662&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189662&action=review


> Source/WebCore/rendering/AutoTableLayout.cpp:251
> +    // if there was no remaining percent, maxWidth is invalid

Nit: Capitalize the first letter and end the sentence with a period.

> Source/WebCore/rendering/FixedTableLayout.cpp:181
> +    minWidth = maxWidth = calcWidthArray();

Julien is right that this style is rare.  I see it mostly when setting min and
max preferred width to the same value.	I don't think it's actually against the
style guide and this seems fine to me.