[webkit-reviews] review granted: [Bug 106594] [chromium] Register newly-created layers for animation : [Attachment 189777] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 106594: [chromium] Register newly-created layers for animation
https://bugs.webkit.org/show_bug.cgi?id=106594

Attachment 189777: Patch
https://bugs.webkit.org/attachment.cgi?id=189777&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189777&action=review


R=me - one change suggested before landing. You don't need to ask me for
another review after moving that, just ask any friendly neighborhood WebKit
committer to help you out.  Thanks for the iterations and explanations!

> Source/WebKit/chromium/src/WebViewImpl.cpp:212
> +class GraphicsLayerFactoryChromium : public GraphicsLayerFactory {

WebViewImpl.cpp is kind of gigantic, so I would consider moving this class out
to its own header/cpp just to cut down on churn.