[webkit-reviews] review granted: [Bug 109916] [Refactoring] Implement RuleCollector : [Attachment 189698] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 109916: [Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916

Attachment 189698: Patch
https://bugs.webkit.org/attachment.cgi?id=189698&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=189698&action=review


Are you using svn copy? We don't want to lose the history. r=me if so.

> Source/WebCore/GNUmakefile.list.am:2658
> +	Source/WebCore/css/ElementRuleCollector.cpp \
> +	Source/WebCore/css/ElementRuleCollector.h \

At some point StyleResolver and the related classes should be moved to a top
level directory of their own.

> Source/WebCore/css/ElementRuleCollector.h:42
> +class ElementRuleCollector {

I don't much like these names (they imply something generic rather than an
implementation detail of StyleResolver) though I don't have great suggestions.
StyleResolverElementRuleCollector is rather long. Maybe we should move this
stuff to its own namespace?