[webkit-reviews] review granted: [Bug 96339] [chromium] Video captions should use full video space when controls disappear : [Attachment 189709] move timer into MediaControlDivElement

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Silvia Pfeiffer
<silviapf at chromium.org>'s request for review:
Bug 96339: [chromium] Video captions should use full video space when controls
disappear
https://bugs.webkit.org/show_bug.cgi?id=96339

Attachment 189709: move timer into MediaControlDivElement
https://bugs.webkit.org/attachment.cgi?id=189709&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189709&action=review


Nice refactoring, thanks for taking the extra time to do it!

> Source/WebCore/html/shadow/MediaControlElementTypes.cpp:154
> +    double duration = document()->page() ?
document()->page()->theme()->mediaControlsFadeInDuration() : 0;
> +
> +    setInlineStyleProperty(CSSPropertyWebkitTransitionProperty,
CSSPropertyOpacity);
> +    setInlineStyleProperty(CSSPropertyWebkitTransitionDuration, duration,
CSSPrimitiveValue::CSS_S);
> +    setInlineStyleProperty(CSSPropertyOpacity, 1.0,
CSSPrimitiveValue::CSS_NUMBER);
> +
> +    setOpaque(true);

Nit: if this was in a separate method it could be shared by makeOpaque and
makeTransparent.