[webkit-reviews] review requested: [Bug 110412] Building for WinCE (cmake) x86 targets fail : [Attachment 189773] Proposed fix

[bugzilla-daemon at webkit.org]

Mark Salisbury <mark.salisbury at hp.com> has asked  for review:
Bug 110412: Building for WinCE (cmake) x86 targets fail
https://bugs.webkit.org/show_bug.cgi?id=110412

Attachment 189773: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=189773&action=review

------- Additional Comments from Mark Salisbury <mark.salisbury at hp.com>
Thanks for your review.

I simplified the description to one line: "Fix for building for x86 targets"

I think we don't want to change behavior in Platform.h.  I like the idea that
if there aren't enough hints given from the compile command line about what
your machine architecture is that you get an error that you need to deal with.

It's easy to focus on what this patch doesn't do, but here's what it does do:
1)  Addresses the bug I've filed (that you can't build the WinCE platform for
x86)
2)  If you are building for ARM, if you don't do anything different current
behavior will continue (WTF_ARM_TRADITIONAL will be defined by
OptionsWinCE.cmake)
3)  If you are building for ARM, you have the option to specify your ARM
architecture version and if you have THUMB2 support.