[webkit-reviews] review denied: [Bug 91611] Downstream state change request support for the GStreamer backend : [Attachment 189770] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 91611: Downstream state change request support for the GStreamer backend
https://bugs.webkit.org/show_bug.cgi?id=91611

Attachment 189770: Patch
https://bugs.webkit.org/attachment.cgi?id=189770&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189770&action=review


> Source/WebCore/ChangeLog:5
> +	   Downstream state change request support for the GStreamer backend
> +	   https://bugs.webkit.org/show_bug.cgi?id=91611
> +

This title tells me nothing about what the change does. Please add a sentence
or two describing what you are changing and why.

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:192
> +    virtual void simulateAudioInterruption() { }

I don't like that this adds a method to every HTMLMediaElement, every
MediaPlayer, and every MediaPlayerPrivate for this platform specific test. Is
there any other way to test this feature? If not, I am not sure the test is
worth the ancillary cost.