[webkit-reviews] review granted: [Bug 110095] Web Inspector: Specify return type of WebInspector.UIString : [Attachment 189504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 07:27:58 PST 2013


Pavel Feldman <pfeldman at chromium.org> has granted Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 110095: Web Inspector: Specify return type of WebInspector.UIString
https://bugs.webkit.org/show_bug.cgi?id=110095

Attachment 189504: Patch
https://bugs.webkit.org/attachment.cgi?id=189504&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189504&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:554
> +			   console.error(WebInspector.UIString("Unknown scope
type: \"%s\"", scope.type));

There is no need to localize it. Otherwise looks good.


More information about the webkit-reviews mailing list