[webkit-reviews] review denied: [Bug 110461] Web Inspector: [Protocol] Generate JS enum definitions. : [Attachment 189710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 07:24:39 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 110461: Web Inspector: [Protocol] Generate JS enum definitions.
https://bugs.webkit.org/show_bug.cgi?id=110461

Attachment 189710: Patch
https://bugs.webkit.org/attachment.cgi?id=189710&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189710&action=review


> Source/WebCore/inspector/front-end/InspectorBackend.js:85
> +	   var domainAndMethod = type.split(".");

You need to call this from loadFromJSONIfNeeded as well.


More information about the webkit-reviews mailing list