[webkit-reviews] review denied: [Bug 110412] Building for WinCE (cmake) x86 targets fail : [Attachment 189559] Proposed fix

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Mark Salisbury
<mark.salisbury at hp.com>'s request for review:
Bug 110412: Building for WinCE (cmake) x86 targets fail
https://bugs.webkit.org/show_bug.cgi?id=110412

Attachment 189559: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=189559&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189559&action=review


> ChangeLog:3
> +	   [WinCE] Don't add definition for WTF_CPU_ARM_TRADITIONAL if we're
not

subject should be only one line long

> Source/cmake/OptionsWinCE.cmake:17
> +	   add_definitions(-DWTF_CPU_ARM_TRADITIONAL)

i don't like to see this in tis file.
What about changeing the Platform.h to make define ARM_TRADITONAL, when no
ARM_THUMB2 was detected?