[webkit-reviews] review granted: [Bug 110137] Add scroll view for new calendar picker : [Attachment 189727] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 110137: Add scroll view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110137

Attachment 189727: Patch
https://bugs.webkit.org/attachment.cgi?id=189727&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189727&action=review


> Source/WebCore/ChangeLog:8
> +
> +	   No new tests. Code not yet used.

Please mention this is a part of Bug 109439.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:906
> +    // Adding property to DOM node so we can access the View instance from
Event.target.

This information should be provided to users of this class. So you should add
this comment to the JsDoc comment.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1003
> +	this.delegate = null;

wrong indentation