[webkit-reviews] review denied: [Bug 110518] Use NativeWebGestureEvent as boundary event type for WebPageProxy : [Attachment 189614] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 110518: Use NativeWebGestureEvent as boundary event type for WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=110518

Attachment 189614: Patch
https://bugs.webkit.org/attachment.cgi?id=189614&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189614&action=review


This makes no sense to me :(

You add support but it is not used anywhere? No test are needed or modified?

What are your GestureEvents for Qt or Nix?

> Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp:240
> +    WebEvent::Type type	       = gestureType;
> +    IntPoint position	       =
fromItemTransform.map(point.pos()).toPoint();
> +    IntPoint screenPosition	       = point.screenPos().toPoint();
> +    WebEvent::Modifiers modifiers   = WebEvent::Modifiers(0);
> +    double timestamp 	       = 0;
> +    IntSize area		       = IntSize(point.rect().size().toSize());

> +    FloatPoint delta 	       = FloatPoint(0, 0);

We don't align values like this in WebKit.