[webkit-reviews] review denied: [Bug 110545] Increase the max preferred width of tables to 1000000 : [Attachment 189661] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 110545: Increase the max preferred width of tables to 1000000
https://bugs.webkit.org/show_bug.cgi?id=110545

Attachment 189661: Patch
https://bugs.webkit.org/attachment.cgi?id=189661&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> > LayoutTests/fast/table/large-shrink-wrapped-width.html:24
> > +<!-- The inner div should fill the container. It doesn't right now because
we artificially limit the tables maxPreferredLogicalWidth to 1000000.
> 
> I really don't think this test benefits from being done as a check-layout
test.
> 
> shouldBe("tableElement.offsetWidth", container.scrollWidth); (or clientWidth
depending on the test)
> 
> would be less code, a lot simpler and avoids the need for hard coded
expectations.

I completely agree, the test could be better IMHO. It is extremely opaque.