[webkit-reviews] review denied: [Bug 110431] INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field : [Attachment 189686] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Kunihiko
Sakamoto <ksakamoto at chromium.org>'s request for review:
Bug 110431: INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
https://bugs.webkit.org/show_bug.cgi?id=110431

Attachment 189686: Patch 2
https://bugs.webkit.org/attachment.cgi?id=189686&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189686&action=review


> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:376
> +    const AtomicString pattern =
m_dateTimeEditElement->getAttribute(HTMLNames::patternAttr);

getAttribute should be fastGetAttribute because it is not a "style" attribute.
You can remove HTMLNames::.

> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:377
> +    if (!pattern.isNull() && !pattern.isEmpty())

isNull() check is unnecessary. isEmpty means "null or 0-length"