[webkit-reviews] review denied: [Bug 90341] createAttribute/setAttributeNode does not properly normalize case : [Attachment 189497] Patch

Thu Feb 21 21:38:16 PST 2013

Hajime Morrita <morrita at google.com> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 90341: createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341

Attachment 189497: Patch
https://bugs.webkit.org/attachment.cgi?id=189497&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189497&action=review

It looks this test could be turned into a text test by using
window.getComputedStyle()

> Source/WebCore/dom/Element.cpp:1727
> +    const QualifiedName& attrName = shouldIgnoreAttributeCase(this) ?
QualifiedName(nullAtom, attrNode->name().lower(), nullAtom) :
attrNode->qualifiedName();

This is wrong. temporal object shouldn't stored in a reference.

> LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity.html:1
> +<html>

It looks this test could be turned into a text test by using
window.getComputedStyle()
Then test will be more readable.