[webkit-reviews] review granted: [Bug 95204] Allow child-frame content in hit-tests. : [Attachment 189041] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 95204: Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

Attachment 189041: Patch
https://bugs.webkit.org/attachment.cgi?id=189041&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189041&action=review


r=me

> Source/WebCore/rendering/RenderFrameBase.cpp:112
> +    FrameView* childFrameView = static_cast<FrameView*>(widget());

I don't like a static_cast without any safety checks so please add (already
mentioned in the previous review):
ASSERT_WITH_SECURITY_IMPLICATION(widget()->isFrameView());