[webkit-reviews] review granted: [Bug 110490] [TextAutosizing] Refactoring to eliminate boolean parameter : [Attachment 189587] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Anton Vayvod
<avayvod at chromium.org>'s request for review:
Bug 110490: [TextAutosizing] Refactoring to eliminate boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=110490

Attachment 189587: Patch
https://bugs.webkit.org/attachment.cgi?id=189587&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189587&action=review


> Source/WebCore/rendering/TextAutosizer.cpp:157
> +    multiplier = std::max(1.0f, multiplier);
>  
> +    return multiplier;

Nit: These 2 lines could be squashed in one:

return std::max(1.0f, multiplier);

> Source/WebCore/rendering/TextAutosizer.h:32
> +#include <WebCore/platform/text/WritingMode.h>

We don't use absolute path when #including in WebCore. This should be enough:

#include "WritingMode.h"